search

rhysmorgan134 / node-CarPlay

MIT License
131 stars 23 forks source link

Add config for Github Workflows #47

Closed steelbrain closed 10 months ago

steelbrain commented 10 months ago

⚠️ Currently targets #45 as base branch

Adds config to lint/test the main package and build/store the example repo. The built example zips can be downloaded by public from each commit's CI log

Fixes https://github.com/rhysmorgan134/node-CarPlay/issues/46

steelbrain commented 10 months ago

It ran successfully https://github.com/steelbrain/node-CarPlay/actions/runs/6213543427

You can also download the associated output file and use it

steelbrain commented 10 months ago

@gozmanyoni I've updated the config to include Typechecking. Re PRs, it's already enabled to run the full config on PRs but it's not "activated" yet as I understand it.

It may get activated automatically once this PR is merged, or if the repository settings are updated; there's a bunch of settings around running actions on branches from 3rd party contributors, not sure how safe it is to enable.

For testing this, in my fork, I didn't have to enable anything besides merging it to one of the branches (next in my case) and it worked well there

gozmanyoni commented 10 months ago

@steelbrain since i merged my branch to next - could you refresh this with the latest changes there?

steelbrain commented 10 months ago

@gozmanyoni It should be up to date now, thanks!

steelbrain commented 10 months ago

@gozmanyoni Seems to be running! https://github.com/rhysmorgan134/node-CarPlay/actions/runs/6216538687