search

rhysmorgan134 / node-CarPlay

MIT License
147 stars 25 forks source link

Android Auto screen size fix #51

Closed steelbrain closed 1 year ago

steelbrain commented 1 year ago

Addresses https://github.com/rhysmorgan134/node-CarPlay/issues/11

steelbrain commented 1 year ago

Github seems to be glitching right now, there's another commit in the branch that's not showing up in the PR https://github.com/rhysmorgan134/node-CarPlay/compare/next...steelbrain:node-CarPlay:steelbrain/android-auto?expand=1

@gozmanyoni I can confirm this does indeed fix the screen size for android. The flickering is still there

While looking around the forks for this repository, I see this guy: https://github.com/rhysmorgan134/node-CarPlay/compare/master...tete1030:node-CarPlay:master (MIT licensed code)

I wonder if there's something we can learn/adapt from what they are doing

Edit: Another thing we should probably document is that if the size is invalid / too large, then Android auto will refuse to start for the phone, downstream consumers can use smaller sizes (4k failed, 1024x600 worked) to fix it if they are getting no video/audio from the usage but their phone says connected

gozmanyoni commented 1 year ago

@steelbrain - introduced some of the changes and more flexible config in - https://github.com/rhysmorgan134/node-CarPlay/pull/55