search

rhysmorgan134 / node-CarPlay

MIT License
131 stars 23 forks source link

Feature: Refactor + extra config + more commands #55

Closed gozmanyoni closed 10 months ago

gozmanyoni commented 10 months ago

Bringing in some changes from this fork - https://github.com/tete1030/node-CarPlay

It adds more commands that we did not map and some message types that i have yet to find in the APK. This also refactors the messaging file a bit, making sure all types are ordered. Lastly - moving a lot of the hard-coded config into driver config, giving the consumers more control.

rhysmorgan134 commented 10 months ago

I'm giving this is a go building it into electron. Just an update as not sure how much testing the node version is getting, but all going well so far! Love the new onmessage method.

gozmanyoni commented 10 months ago

@steelbrain @rhysmorgan134 any objections to merging this one into next?

No degradation observed during local testing

steelbrain commented 10 months ago

I have no objections, looks good on my end. Thanks for working on this!

rhysmorgan134 commented 10 months ago

No objections from me!