search

rhysnewell / aviary

A hybrid assembly and MAG recovery pipeline (and more!)
GNU General Public License v3.0
81 stars 12 forks source link

attempt to fix #166 by interleaving reads correctly #167

Closed rhysnewell closed 11 months ago

rhysnewell commented 11 months ago

minor fixes from #163 and major fix for #166 Version updates for #165

AroneyS commented 11 months ago

Still running some tests. Added gzip.open to write in gz. pigz would be faster, but I'm not sure how to do that with append.

rhysnewell commented 11 months ago

I had been thinking about this, I think the best option would be to append all reads to a non-compressed file and then use pigz at the end to compress the output and make sure the uncompressed file is deleted. Would give the best compression and likely be faster

AroneyS commented 11 months ago

Yeh that makes sense. Do you have time now or should I give it a go?

rhysnewell commented 11 months ago

I won't have time until later today

rhysnewell commented 11 months ago

@AroneyS Any further commits incoming or ready to merge?

AroneyS commented 11 months ago

I think its ready.