rhysnhall / etsy-php-sdk

PHP SDK for Etsy API v3.
MIT License
47 stars 36 forks source link

Enable pagination support for Receipts #15

Closed guerrillacontra closed 2 years ago

guerrillacontra commented 2 years ago

It should be supported based on the official docs (offset+limit)

https://developers.etsy.com/documentation/reference#operation/getShopReceipts

But in Collection we have:

const PAGINATION_SUPPORT = [ "Shop", "Review", "Listing" ];

Which prevents me from being able to pull in more than 100 orders without writing my own paginator.

$receipts = $shop->getReceipts([ 'limit'=>y, 'offset'=>y ]);

rhysnhall commented 2 years ago

Thanks for bringing this up @guerrillacontra At the time of writing, the API did not support this. Good to see they have added it. I have fallen behind on keeping up to date with their changes. I have also reviewed and added pagination support for Transactions and LedgerEntry.

Patch incoming.