search

rhyswynne / easy-digital-downloads-taxamo-integration

Integrate Taxamo into Easy Digital Downloads. Make yourself Compatible with the VATMOSS EU Legislation
2 stars 6 forks source link

Billing address required when cart total = 0.00 #30

Closed jakemcmurchie closed 9 years ago

jakemcmurchie commented 9 years ago

If the cart total after discount codes applied is zero, the billing address fields aren't displayed, but a "Please confirm that the billing address is correct." error is displayed when "purchase" is clicked.

More... taxamo-edd-integration.php line 421 check_self_declaration() is set to return if edd_get_cart_subtotal() == 0 But edd_get_cart_subtotal() "Gets the total price amount in the cart before taxes and before any discounts"

rhyswynne commented 9 years ago

I can replicate :)

Right not sure when I will be able to look at it, but so I remember.

If you buy a free product, this error #20 is fixed, so doesn't occur then.

HOWEVER if you buy a paid product and get a 100% discount, this error does occur.

Occurs if billing address is not in IP range.

jakemcmurchie commented 9 years ago

Thanks Rhys. If it helps [anyone else], I've changed line 421 if ( edd_get_cart_subtotal() == 0 ) { to if ( edd_get_cart_total() == 0 ) {

rhyswynne commented 9 years ago

Hi @jakemcmurchie,

Could you have a look at https://github.com/rhyswynne/easy-digital-downloads-taxamo-integration/commit/d61341d679cbee71241961ceeaca7963e31de849 please? It's 1.4.1-beta and potentially fixes it.

jakemcmurchie commented 9 years ago

Thank you Rhys. Yes, that's the fix I implemented and so far seems to work for my use case. I'll investigate further when I have a little time in the next few days. I'm currently unable to test in countries outside the UK (where a different tax rate will apply).

rhyswynne commented 9 years ago

Going to close this, as I think if something was broken because of it it'd turn up by now.

rhyswynne commented 9 years ago

If not feel free to reopen :)

jakemcmurchie commented 9 years ago

Seems to be working well to me. Thanks Rhys.

On Sunday, 14 June 2015, Rhys Wynne notifications@github.com wrote:

If not feel free to reopen :)

— Reply to this email directly or view it on GitHub https://github.com/rhyswynne/easy-digital-downloads-taxamo-integration/issues/30#issuecomment-111820676 .