search

rhyswynne / easy-digital-downloads-taxamo-integration

Integrate Taxamo into Easy Digital Downloads. Make yourself Compatible with the VATMOSS EU Legislation
2 stars 6 forks source link

v1.5 Brings Back The #28 Bug #31

Closed maurisrx closed 9 years ago

maurisrx commented 9 years ago

Hello,

I've just updated the plugin to v1.5 and encountered an old bug #28 is back again in the plugin. Is v1.5 a critical update so I can skip it and stick with v1.4?

The v1.5 bug image: http://screencast.com/t/pheHcN53af1

Thanks, Mauris

rhyswynne commented 9 years ago

Hi Mauris,

Gah! I thought I tested for it :(.

It's not a critical update. It's only a critical update if you want prices including tax. If you want it excluding tax, then you don't need to update.

I thought I got it. I will look at it over the weekend and prepare a fix.

maurisrx commented 9 years ago

Thank you Ryhs for the answer. I will downgrade to v1.4 for the moment to get it worked again

rhyswynne commented 9 years ago

No problem. Sorry about this - I thought I got it :(

maurisrx commented 9 years ago

Never mind, v1.4 works fine for me though. Thanks for the effort on the plugin.

rhyswynne commented 9 years ago

Does 1.5 still work okay if checkout excludes tax? I can only seem to see the above if checkout includes tax.

rhyswynne commented 9 years ago

Have a look at https://github.com/rhyswynne/easy-digital-downloads-taxamo-integration/commit/6692651d8c7896e3059bbeeb37821b39dafaa69f, this may fix this issue.

maurisrx commented 9 years ago

Thanks, it seems it has fixed the bug: http://screencast.com/t/ESu7ELNE6W

rhyswynne commented 9 years ago

Superb! Going to close this.