rhyswynne / easy-digital-downloads-taxamo-integration

Integrate Taxamo into Easy Digital Downloads. Make yourself Compatible with the VATMOSS EU Legislation
2 stars 6 forks source link

Lie about my country #5

Closed samikeijonen closed 9 years ago

samikeijonen commented 9 years ago

If I lie my country at the checkout, I can still purchase without any errors but that won't be recorded in Taxamo. Should it be this way?

rhyswynne commented 9 years ago

Yeah, this was something that was causing us an issue. Effectively the order will be submitted to Taxamo as it is invalid. Previously this caused a Fatal Error, but instead a flag is set in the payment_meta called taxamo_unsubmitted, and a message is added to the payment note.

image

I'm not 100% sure what to do with this yet :-/

samikeijonen commented 9 years ago

Yes, there it is. I also have lot's of other purchase info after Reason: Validation error for https://api.taxamo.com/api/v1/transactions:. But I guess that's ok:)

rhyswynne commented 9 years ago

Yeah. The option is there to create something a bit more worthwhile and attractive....just not sure what :-/

(thanks for the feedback though!)

rhyswynne commented 9 years ago

Right we have an update from Taxamo. Turns out we'd have to self declare as a last resort. So will integrate this (see #6)

rhyswynne commented 9 years ago

Hi @samikeijonen. The latest commit (fb36a1e) should prevent solve this issue (give #6 a read too), if happy, will close.

samikeijonen commented 9 years ago

I did a quick test and I can see the toggled checkbox when I lie about my country.

rhyswynne commented 9 years ago

Going to close this. As I think #6 should've fixed it.