riak-core-lite / riak_core_lite

Distributed systems infrastructure used by Riak.
Apache License 2.0
80 stars 13 forks source link

Insert RclRef into GitHub Action #84

Closed WoelkiM closed 3 years ago

WoelkiM commented 3 years ago

Insert and run RclRef tests and RclBench.

WoelkiM commented 3 years ago

Problems with Erlang version 21. The current ct are only executed under version 22, 23.

WoelkiM commented 3 years ago

Possible bench implementation:

- name: Checkout repo bench
  uses: actions/checkout@v2
  with:
    repository: riak-core-lite/rcl_bench
    path: ./rcl_bench/

- name: start bench
  run: |
    cd rclref
    make devrel 
    make devrel-start
    make devrel-join
    make devrel-cluster-plan
    make devrel-cluster-commit
    cd ../rcl_bench
    make run

Problem: {error, "Incomplete form (missing .)??"}; See: (https://github.com/wattlebirdaz/rclref/issues/6)

marianoguerra commented 3 years ago

at some point doing rpc eval calls to a node from the command line changed from requiring a dot at the end to not requiring it, maybe in 21 the dot is required?

WoelkiM commented 3 years ago

This is quite possible, but for me the error occurred with Erlang version 23. I will check how it behaves under 21.

edit: The error message under Erlang 21: escript: exception error: undefined function rebar3:main/1 in function escript:run/2 (escript.erl, line 758) in call from escript:start/1 (escript.erl, line 277) in call from init:start_em/1 in call from init:do_boot/3 make: *** [ct] Error 127 Makefile:47: recipe for target 'ct' failed

WoelkiM commented 3 years ago

When running make devrel the problem is that in github actions unfortunately an error occurs. example commit link(my fork): "connect rcl_bench Erlang CI #43" (Erlang 23) "mkdir -p _build/dev3/rel/rclref/../rclref_config /__w/_temp/1c3e05fd-8a1d-4484-a65b-7277e1c164b5.sh: 2: /__w/_temp/1c3e05fd-8a1d-4484-a65b-7277e1c164b5.sh: : not found"

This error did not occur in the previous executions and I can't understand why it occurs now. My thoughts are that either connections are no longer there or old files/processes are not terminated correctly. Unfortunately I haven't found a solution yet.

albsch commented 3 years ago

We add a new issue for rcl_bench and close this one.