RObject#siblings has return type ([RObject] | RObject)

[aphyr]

I think a pluralized method returning a list like #siblings should always return an array. As it stands, when only one sibling exists it returns that RObject directly, which makes it difficult to write code using #siblings without case statements.

@seancribbs, @adamhunter, @myronmarston, @duff, @ntalbott, thoughts? Shall I change #siblings to return [self] when no conflict is present?

[myronmarston]

That makes sense to me.

[seancribbs]

Do it. This will be the first step toward making it be "#values" and having a separate Value class that is simply delegated to at the top level RObject.

On Tue, Nov 15, 2011 at 4:07 PM, Kyle Kingsbury < reply@reply.github.com

wrote:

I think a pluralized method returning a list like #siblings should always return an array. As it stands, when only one sibling exists it returns that RObject directly, which makes it difficult to write code using

siblings without case statements.

@seancribbs, @adamhunter, @myronmarsten, @duff, @ntalbott, thoughts? Shall I change #siblings to return [self] when no conflict is present?

---

Reply to this email directly or view it on GitHub: https://github.com/seancribbs/ripple/issues/239

Sean Cribbs sean@basho.com Developer Advocate Basho Technologies, Inc. http://www.basho.com/

[ntalbott]

Yes please!

[duff]

+1

[aphyr]

Coming up shortly. :)

[aphyr]

Fixed by 432b3828f99463fcea296280adf58086af494361