seancribbs
commented
12 years ago Looks great, thanks.
Sean Cribbs
On Nov 26, 2011, at 2:46 PM, John Leachreply@reply.github.com wrote:
Just a simple missing include, but I added a basic BeefcakeProtobuffsBackend#load_object test to reproduce the error too
(though beware my stubbing as I don't really know exactly what pb message data it was expecting).
You can merge this Pull Request by running:
git pull https://github.com/brightbox/ripple master
Or you can view, comment on it, or merge it online at:
https://github.com/seancribbs/ripple/pull/250
-- Commit Summary --
- Fix undefined method errors in BeefcakeProtobuffsBackend
-- File Changes --
M riak-client/lib/riak/client/protobuffs_backend.rb (1) A riak-client/spec/riak/beefcake_protobuffs_backend/object_methods_spec.rb (23)
-- Patch Links --
https://github.com/seancribbs/ripple/pull/250.patch https://github.com/seancribbs/ripple/pull/250.diff
Reply to this email directly or view it on GitHub: https://github.com/seancribbs/ripple/pull/250
Just a simple missing include, but I added a basic BeefcakeProtobuffsBackend#load_object test to reproduce the error too
(though beware my stubbing as I don't really know exactly what pb message data it was expecting).