riak-ripple / ripple

A rich Ruby modeling layer for Riak, Basho's distributed database
Other
619 stars 152 forks source link

Add generator specs and fix cosmetic indentation issue #263

Closed seancribbs closed 12 years ago

seancribbs commented 12 years ago

This adds specs for all included Rails generators and fixes a minor cosmetic issue related to existing indentation in the test/spec helpers as described in #232.

Along the way, some issues were identified with the test server, including missing a trailing slash on PIPE_DIR and some incompatibilities in the KV backend introduced in the upcoming 1.1 release.

Other salient points:

I would prefer a Basho employee review the test backend changes, a committer familiar with Rails/RSpec review the generator changes.

ntalbott commented 12 years ago

Had a read-through: +1.

myronmarston commented 12 years ago

I made a few comments, but it looks good otherwise.