search

riak-ripple / ripple

A rich Ruby modeling layer for Riak, Basho's distributed database
Other
619 stars 152 forks source link

Rails 3.2 support #275

Closed myabc closed 12 years ago

myabc commented 12 years ago

The following commits should get the spec suite running green on Rails 3.2.

Issue #258 should also be fixed with this Pull Request.

I could do with some feedback, particular with reference to AttributeMethods#method_missing? where I just went with what works, rather than spending too much time poring over Active Model's implementation changes.

ntalbott commented 12 years ago

In general this looks solid (haven't had a chance to run it locally), but I agree that the AttributeMethods#method_missing? code looks sketchy. If I get a chance to try this out on 3.2, I'll be sure to take a look and see if I can figure out what actually broke there and a better way of fixing it. Don't let me hold anyone else up, though :)

myabc commented 12 years ago

(if reviewing this patch, I recommend ignoring whitespace… i.e. https://github.com/seancribbs/ripple/pull/275/files?w=1)

seancribbs commented 12 years ago

@myabc You can also run rake clean_whitespace if that's an issue.

datenimperator commented 12 years ago

I'm about to start a new app that will use Riak, and I'd like to start from Rails 3.2.x. Can you please merge this in and update the gem, if at all possible? Thanks!