search

riak-ripple / ripple

A rich Ruby modeling layer for Riak, Basho's distributed database
Other
619 stars 152 forks source link

Fix some issues with associations and properties. #282

Closed seancribbs closed 12 years ago

seancribbs commented 12 years ago

Kernel#Array -> Array::wrap in associations has better semantics. Also, define attributes methods after adding properties should reduce method_missing overhead. Should fix #268.

ntalbott commented 12 years ago

Didn't run the tests - going to assume you're doing that - but reviewed the diff and it looks good to me. :+1:

seancribbs commented 12 years ago

@ntalbott There are no external functionality changes, hence no changes in the tests. I attempted to port assert_performance_* but found it lacking in the ability to verify the behavior I wanted to check.

ntalbott commented 12 years ago

Sorry, didn't mean to imply you needed to write tests; rather was just saying I trusted you to make sure existing tests still pass with these changes.

seancribbs commented 12 years ago

@ntalbott I know. ;) Just trying to add some more context.