search

rialto-php / puphpeteer

A Puppeteer bridge for PHP, supporting the entire API.
MIT License
1.34k stars 204 forks source link

Upgrade to symfony ^6.0 to add compatibility with Laravel 9 #170

Open eusonlito opened 2 years ago

eusonlito commented 2 years ago

Hello! symfony dependencies on this project are 4 and 5 and Laravel 9 requires version 6.

  Problem 1
    - Root composer.json requires nesk/puphpeteer ^2.0 -> satisfiable by nesk/puphpeteer[2.0.0].
    - laravel/framework[v9.0.0-beta.1, ..., 9.x-dev] require symfony/process ^6.0 -> satisfiable by symfony/process[v6.0.0-BETA1, ..., 6.1.x-dev].
    - Conclusion: don't install symfony/process v6.0.3 (conflict analysis result)
    - Root composer.json requires laravel/framework ^9.0 -> satisfiable by laravel/framework[v9.0.0-beta.1, ..., 9.x-dev].

Is possible to add compatibility with Symfony 6?

Thanks!

eusonlito commented 2 years ago

I have forked nesk/puphpeteer and nesk/rialto while I'm waiting to update.

You can use this configuration in composer.json to work with Laravel 9:

    "require": {
        "laravel/framework": "^9.5",
        "nesk/puphpeteer": "dev-master",
        "nesk/rialto": "dev-dev as 1.2"
    },
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/eusonlito/puphpeteer"
        },

        {
            "type": "vcs",
            "url": "https://github.com/eusonlito/rialto"
        }
    ],