ProcessSupervisor unconditionally stops browser on __destruct

rialto-php / puphpeteer

A Puppeteer bridge for PHP, supporting the entire API.

MIT License

1.34k stars 204 forks source link

ProcessSupervisor unconditionally stops browser on __destruct #174

Closed NigelCunningham closed 2 years ago

NigelCunningham commented 2 years ago

Hi there. Thanks for this project.

I'd like to have a long-running puppeteer instance but the ProcessSupervisor class's __destruct method doesn't provide a way to say "Don't stop the browser". Could one be added, please? Happy to create a PR.

Regards,

Nigel

NigelCunningham commented 2 years ago

Oh, I missed the fact that the process supervisor is in @nesk/rialto. I'll open an issue there instead.