search

rianadon / Cosmos-Keyboards

Taking Keyboards to the Final Frontier
https://ryanis.cool/cosmos
GNU Affero General Public License v3.0
221 stars 24 forks source link

Move docker env to docker folder #12

Closed rianadon closed 6 months ago

rianadon commented 8 months ago

It looks like since the RUN command is already sourcing the .env file, it's not necessary to include it in the docker-compose file. This leaves us without any way to supply runtime variables, but I don't imagine I'll be adding any runtime environment variables soon.

The end result is that docker-compose runs without any error if no .env file is present, so there's no need for any scripts to autocreate a .env file.

Btw I've added a GitHub action to docker-compose build so we catch any future regressions. This action could potentially be expanded to publish to dockerhub.

vercel[bot] commented 8 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
cosmos-keyboards ✅ Ready (Inspect) Visit Preview Jan 31, 2024 7:47pm