rianadon / Cosmos-Keyboards

Taking Keyboards to the Final Frontier
https://ryanis.cool/cosmos
GNU Affero General Public License v3.0
179 stars 22 forks source link

Case is cut horizontally #26

Open ngrigoriev opened 1 week ago

ngrigoriev commented 1 week ago

I have just attempted to build a case.

URL: https://ryanis.cool/cosmos/beta#cf:ChYIBRAGWAEYBCACKNcBMM0BUAJAAEgAGgYIBhAAGABCUwgD4AEBeAPYAQEQAUgASABIAEgASABIAEgAYABoAHABGAEgASgBmAH0A6gB6AegAcgBsAEAkAGEB7gBAIABFDAAOChYCIgBAcABAMgB2ATQAYQH

First, Prusa complains about the STL errors.

image

Next, it appears that the model has a gap of some sort going across the entire case, parallel to the bottom, just above the connector holes:

image

image

ngrigoriev commented 1 week ago

After experimenting a bit more, I found that setting "Wall Shrouding" parameter to any value >0 results in this. Setting it to 0 makes the case solid.

rianadon commented 1 week ago

It looks like this has something to do with the produced web being invalid. If I import the step file from both cases into PrusaSlicer, the webs only show up when wall shrouding is disabled. I also see when importing the STL that the lower left key in the thumb cluster turns dark green (which means the mesh is doing odd things there).

My guess is that the web curling in right here might have something to do with it.

image

My last build with both rounded sides & wall shrouding turned on ran into issues with the rounded sides clipping into the keycaps, resulting in me spending hours sanding down the walls so they no longer collide with the keycaps. You'll probably avoid that problem with shrouding of only 2mm, but it looks like a similar issue is to blame here.

rianadon commented 1 week ago

It does look like that little spot is the issue. I took your model through the yet-to-be-released V3 interface in order to position a rectangle / blank keycap right next to that bottom left key, and the model successfully sliced.

image image

I can send you the files if you'd like, but there are some bugs I've yet to fix with the ways column staggers get applied which results in the key positions being ever so slightly different from what you have.

V3 should be out and bug-free by end of June, so you could also wait until then. Cheers!

ngrigoriev commented 1 week ago

V3 is the main branch? If so, I can try myself.

rianadon commented 1 week ago

I haven't pushed the changes yet. I keep the website and the repository synced so that everyone gets new features at the same time.

I did however make the same change in expert mode. It sliced without problems in prusaslicer, so hopefully will work for you. It is harder to edit things in expert mode, but what I've done is keep one tab with expert, one tab with basic/advanced, and when you make a change in basic/advanced go to expert and merge the two codes together. V3 will also add a way to take your changes in expert and convert them to basic/advanced.