rianadon / dactyl-configurator

Generate Dactyl keyboard designs from your browser.
https://ryanis.cool/dactyl
GNU Affero General Public License v3.0
146 stars 15 forks source link

[Feature] Carbonfet thumb cluster #11

Closed dunk2k closed 1 year ago

dunk2k commented 1 year ago

Would it be possible to add the Carbonfet thumb cluster?

Thumb Key Count: 6 (Carbonfet)

rianadon commented 1 year ago

It would definitely be feasible. At the same time, it would be no easy change. The layout of the carbonfet thumb cluster diverges from the manuform cluster, and merely publishing a new shaping preset would not be enough.

Even if all the keys were positioned correctly, the existing wall generation would attach the walls of the case to the wrong keys, resulting in lots of self-intersecting geometry and an ugly keyboard. The dactly code is written such that all the walls are laid out by hand, and adding a new custom thumb cluster is a code-and-time-intensive feat (the diff of carbonfet's src/dactyl_keyboard/dactly.clj shows roughly what's required).

Personally I'd much prefer an algorithm to solve wall positioning rather than writing it out by hand for every custom thumb cluster, and that's one of the chief reasons I created the Cosmos Keyboard Generator. If you haven't already played with it I suggest you give the beta a try or wait until it's released. The models are similar to the dactyl and there's Carbonfet thumb clusters and much much more :)

I'm not opposed to accepting a PR that added Carbonfet thumb clusters, but I fear the burden of maintaining the hundred lines of code per additional new thumb cluster. I'm going to close this as I don't intend on adding new custom thumb clusters here.

dunk2k commented 1 year ago

A genuinely insightful response, many thanks 🙂

rianadon commented 1 year ago

Thank you! I like to give some substance to my vetos.

I also just saw you joined the Cosmos discord server. Welcome!