rianadon / dactyl-configurator

Generate Dactyl keyboard designs from your browser.
https://ryanis.cool/dactyl
GNU Affero General Public License v3.0
146 stars 15 forks source link

Added nathanielks's Nice!Nane connectors #13

Closed sethtroisi closed 1 year ago

rianadon commented 1 year ago

Thanks for the PR! I did not know about this holder, and it's great to see support for another board, especially a wireless one!

This external holder is taller than the other holders, so it will not fit into the model. I'd prefer to link to ones that are all the same size rather than add an extra setting to configure the height of the cutout. I'm sorry for creating new rules about the connectors page after you've submitted your PR.

I'm going to reject the PR, but I'll make a note of this holder's existence on the page.