rianadon / the-energy-detective-py

Unofficial library for reading from The Energy Detective power meters
0 stars 3 forks source link

Add production support #2

Closed realumhelp closed 3 years ago

realumhelp commented 3 years ago

Fixes #1 -

Filled in many blanks left in the TED5000 interface and commonized as much as I could to get it in a place where it can parse Production and Consumption MTU's. Used http://demo.theenergydetective.com to test against since I don't have a TED5000 system. Got the TED5000 fixtures from the demo.

The TED6000 side didn't change a whole huge amount but I did do a bit a math to make the values coming from TED5000 and TED6000 the same.

Interface Changes:

realumhelp commented 3 years ago

Looks great! Thank you so much for digging into the API and fixing my typos. It looks like you spent a lot of time on this, and I'm glad you even added lots of tests!

I added a few a comments in the review. Hopefully I am not being too picky.

I hopefully resolved all of your comments.

rianadon commented 3 years ago

Awesome! Thank you so much!