riannucci / rietveldv2

rietveldv2
Apache License 2.0
1 stars 1 forks source link

Pluggable Themes #1

Open riannucci opened 10 years ago

riannucci commented 10 years ago

I think it will be necessary in the near future to have per-user themes. This isn't as daunting as It would seem, since I've already decreed (and no one has objected :smile: ) that all write-access to the datastore will happen through the API. Additionally, since the API is versioned, and we have pretty easy ways to test HTTP endpoints in different conditions, it would be trivial to extend the api to support new features, while allowing the old api to continue supporting old themes, as necessary.

I see at least 2 themes that will be necessary in the near future

In addition to being selectable on a per-user basis, it would be great if themes had a way to expose options on a per-theme basis which showed up in the user settings. In particular, that would have made the introduction of colored reviewers and bolded 'activity' to the current theme easier (since there would be a way to opt-out or opt-in). In the current rietveld, there was essentially no easy way to do that, which lead to a lot of grief on various mailing lists.

riannucci commented 10 years ago

This probably depends on #4