search

riarumoda / KernelSU-4.4

A Kernel based root solution for Android. Now adapted for Linux Kernel 4.4 + Google GCC 4.9
https://kernelsu.org
GNU General Public License v3.0
1 stars 3 forks source link

SELinux domain transitions #2

Open powellnorma opened 2 months ago

powellnorma commented 2 months ago

I think adding https://github.com/tiann/KernelSU/commit/0950fbba5e79820da539054f6eb6d1d48ec96ff4 would be helpful - See https://github.com/tiann/KernelSU/issues/270#issuecomment-1441547311

powellnorma commented 2 months ago

I made a PR (#3) - One also has to hook security_bounded_transition manually now

riarumoda commented 2 months ago

the commits in here doesn't require additional hooks into the kernel right? since i wanted this fork to close as the original as possible but still adding compatibility for 4.4 kernels

riarumoda commented 2 months ago

since you said it need to hook security_bounded_transition, i might gonna read this wrong since i just got home from college and it's already night.

powellnorma commented 2 months ago

the commits in here doesn't require additional hooks into the kernel right?

They are not required in a sense that it will still build fine - However then the problem will still occur (that ksud does not start during boot, at least on some phones which use the 'nosuid' flag)

This problems only occurs for older kernels (< 4.14 ), so I think its a reasonable deviation from the original