We need a setup in which errors are kept in the default sqlite store, while redirects are stored in the main Laravel database. Doing this caused all sorts of DX issues which this PR tries to solve.
[!Tip]
The DOCUMENTATION.md diff explains how this new setup works.
Issues
There is just one connection config for both errors and redirects.
This meant we had to create our own custom repository to use a seperate connection for redirects. This PR adds seperate redirect_connection and error_connection config values.
The default sqlite database is called errors.sqlite
It took a little while until I realized that eloquent redirects are stored here as well. This PR renames the database to redirect.sqlite.
The README.md is outdated
The repository classes mentioned do not exist anymore. This PR removes outdated and duplicate documentation in the README.md and adds updated documentation to the DOCUMENTATION.md.
The connection name redirect was unclear at first
Renaming it to redirect-sqlite clarified this.
The migration name create_redirect_tables implies that it contains all redirect tables
You need to open the migration files to figure out the difference between:
create_redirect_tables
create_eloquent_redirect_table
This PR renames them to:
create_redirect_error_tables
create_redirect_redirects_table
The different migrations contain clearer tags. This makes it easier for developers to publish just the migration(s) they need.
Considerations
There is backwards compatibility with the connection config. connection currently overrides error_connection and redirect_connection. In my opinion, it would be better to create a new major version and drop connection support.
I wanted to create an update script for the errors.sqlite to redirect.sqlite rename. This causes problems as the boot method in the service provider runs before the update scripts. This is the reason why this logic has been put in the boot method.
riasvdv
commented
8 months ago
Hi again! 😅
We need a setup in which errors are kept in the default sqlite store, while redirects are stored in the main Laravel database. Doing this caused all sorts of DX issues which this PR tries to solve.
Issues
There is just one
connectionconfig for both errors and redirects.This meant we had to create our own custom repository to use a seperate connection for redirects. This PR adds seperate
redirect_connectionanderror_connectionconfig values.The default sqlite database is called
errors.sqliteIt took a little while until I realized that eloquent redirects are stored here as well. This PR renames the database to
redirect.sqlite.The
README.mdis outdatedThe repository classes mentioned do not exist anymore. This PR removes outdated and duplicate documentation in the
README.mdand adds updated documentation to theDOCUMENTATION.md.The connection name
redirectwas unclear at firstRenaming it to
redirect-sqliteclarified this.The migration name
create_redirect_tablesimplies that it contains all redirect tablesYou need to open the migration files to figure out the difference between:
create_redirect_tablescreate_eloquent_redirect_tableThis PR renames them to:
create_redirect_error_tablescreate_redirect_redirects_tableThe different migrations contain clearer tags. This makes it easier for developers to publish just the migration(s) they need.
Considerations
connectionconfig.connectioncurrently overrideserror_connectionandredirect_connection. In my opinion, it would be better to create a new major version and dropconnectionsupport.errors.sqlitetoredirect.sqliterename. This causes problems as the boot method in the service provider runs before the update scripts. This is the reason why this logic has been put in the boot method.