search

riatelab / cartography

Thematic Cartography for R
http://riatelab.github.io/cartography/docs/
397 stars 46 forks source link

Added 59 new providers: #60

Closed dieghernan closed 4 years ago

dieghernan commented 4 years ago

See: https://leaflet-extras.github.io/leaflet-providers/preview

Following #58

dieghernan commented 4 years ago

Need to change some sign

dieghernan commented 4 years ago

Change enconding for some attributions

dieghernan commented 4 years ago

Travis build of this branch:

Build Status

rCarto commented 4 years ago

Very nice! I'm going to merge the pull request. The only thing: some providers were already available ('osm' == 'OpenStreetMap', 'stamenbw' == 'Stamen.Watercolor'...) under other type names. I think it is better to use the original leaflet-provider names as you do. I'll add something to allow the previous names ("osm", "hotstyle", "hikebike", "osmgrayscale", "stamenbw", "stamenwatercolor", "cartodark", "cartolight", "opentopomap") to be used for backward compatibility.

dieghernan commented 4 years ago

hi @rCarto, I also had that in mind, those are duplicates e.g cartodark & CartoDB.Dark, so backwards compatibility is ensured and also full compatibility with user already familiarised with Leaflet, I just thought that was the best way to do it

arthurgailes commented 4 years ago

Just wanted to say thank you both. This is extremely useful in creating publishable maps.