Closed rlh1994 closed 2 years ago
Merging #17 (dbf5129) into main (259daa4) will increase coverage by
0.07%
. The diff coverage is100.00%
.:exclamation: Current head dbf5129 differs from pull request most recent head 36fd243. Consider uploading reports for the commit 36fd243 to get more accurate results
@@ Coverage Diff @@
## main #17 +/- ##
==========================================
+ Coverage 86.33% 86.41% +0.07%
==========================================
Files 4 4
Lines 183 184 +1
==========================================
+ Hits 158 159 +1
Misses 25 25
Impacted Files | Coverage Δ | |
---|---|---|
R/get_tiles.R | 87.91% <100.00%> (+0.08%) |
:arrow_up: |
Help us with your feedback. Take ten seconds to tell us how you rate us.
Thank you very much, that's useful!
Small issue I found but was easy enough to fix on a local clone so wanted to just contribute it - it might not be the most elegant way but it solves the issue using a base function.
The issue is that
apply
coerces everything to a character for the OSM maps when thex
value is passed into thedl_t
function which causes a failure when you are downloading a tileset that spans (on the x or y columns) values with a different number of units such as in the below example.Created on 2022-08-01 by the reprex package (v2.0.1)
This change fixes this issue and correctly completes the filename
Created on 2022-08-01 by the reprex package (v2.0.1)
I updated the news but left the version number increased on the DESCRIPTION as this already didn't match so was unsure if that needed changing.
Hopefully this helps!