search

riazXrazor / udemy-dl

Nodejs script to download a udemy.com course, for personal offline use
285 stars 68 forks source link

Friendly file names #2

Closed JC-JackClark closed 7 years ago

JC-JackClark commented 7 years ago

Hi, when a video section/video title contains the following characters (on windows):

< (less than)

(greater than) : (colon) " (double quote) / (forward slash) \ (backslash) | (vertical bar or pipe) ? (question mark)

  • (asterisk)

The program hangs. Maybe a string replace on these characters?

Thanks,

riazXrazor commented 7 years ago

Hi Jack, Thanks for your feed, you are right, will fix it ASAP. Thanks,

riazXrazor commented 7 years ago

Hi Jack, i have pushed a fix and updated the npm package, plz can you confirm that the issue is fixed. Thanks.

JC-JackClark commented 7 years ago

Thanks for fixing quickly, unfortunately, that didn't work with the course I tried.

I have created a pull request. I will close the issue regardless. (I haven't updated npm package)

Thanks,

riazXrazor commented 7 years ago

i was trying with the slugify, if that didn't work i was going to think something else, but you did it, thanks a ton.