rib / jsonwebtokens

A rust implementation of Json Web Tokens
MIT License
43 stars 7 forks source link

Revert recent change to avoid using Arc:ptr_eq #29

Closed rib closed 1 year ago

rib commented 1 year ago

Due to a clippy warning about Arc::ptr_eq potentially comparing vtable meta data associated with wide pointers there was a recent change to explicitly only check the address pointers and discard any wide pointer meta data.

The Rust libs team has since resolved to update Arc::ptr_eq so that it doesn't compare meta data for the wrapped value (such as a dyn trait vtable): https://github.com/rust-lang/rust/issues/103763

In the meantime we can silence this clippy suggestion since the vtable is benign in this case anyway: https://github.com/rust-lang/rust-clippy/issues/6524

Fixes: #26