search

riban-bw / CodeBlocks-Sming-Wizard

Project wizard for Code::Blocks to create a Sming project
GNU Lesser General Public License v3.0
0 stars 1 forks source link

SPI size and mode, custom paths #3

Closed HappyCodingRobot closed 6 years ago

HappyCodingRobot commented 6 years ago

Added function to SPI selection to write to Makefile Added input for custom ESP_HOME and SMING_HOME pathes

riban-bw commented 6 years ago

Thanks for this. I am just tweaking some stuff which is similar to some of the things you have done so the PR may require a tweak to avoid conflict. I hadn't added custom paths because I felt this made the project Makefile too user specific, e.g. if you want to share your project via github, it would have a Makefile that was specific to your system which may publish info you don't want to, e.g. your name / configuration of your build environment. I may be being over cautious and your use of a check box to allow this to be enabled probably mitigates my concerns, i.e. a user may decide whether to use Env Vars or write their paths to the Makefile.

HappyCodingRobot commented 6 years ago

I understand your concerns regarding to portability. Maybe it is a better way to edit the Makefile afterwards for those who really want to change it. Your changes for the flash parameter looks way better so i think i drop this PR as the important parts now work.

HappyCodingRobot commented 6 years ago

Do you found a way to solve the missing dependency parts in the wizard (paths to header, ..)

riban-bw commented 6 years ago

I may still add the paths to the wizard. I quite like the idea of having the option with it disabled by default. I have updated README,md with a link to the Codeblocks issue regarding autocomplete. I think I have a partial fix but am struggling to compile Codeblocks to test it. A proper fix may require significant reworking of Codeblocks.