search

ribbons / RadioDownloader

An easy to use application for managing podcast subscriptions and downloads.
https://nerdoftheherd.com/tools/radiodld/
GNU General Public License v3.0
15 stars 11 forks source link

Stopped the StoreProgrammeInfo function from concealing provider exceptions. #112

Closed ribbons closed 11 years ago

ribbons commented 11 years ago

Original report from Matt Robinson at 17:12:13 on 2010-05-28

Currently, when a user selects a subscription in the episode list, UpdateProgInfoIfRequiredAsync ends up being called, which calls StoreProgrammeInfo but discards any information about exceptions being returned from it. As programme information is not updated automatically, it would be better to move the exception handling code from FindNewPluginInst_FoundNew into StoreProgrammeInfo itself so that the Exceptions are never discarded.

Imported from Bug 269 in the NerdoftheHerd.com Bugzilla.

ribbons commented 11 years ago

Original comment from Matt Robinson at 11:32:30 on 2010-07-18

Resolved by removing the exception handling code from the StoreProgrammeInfo function in a5ec492. This does mean that exceptions in the provider will now crash the application, but this is better than them being caught and silently discarded some of the time.