ribbons / RadioDownloader

An easy to use application for managing podcast subscriptions and downloads.
https://nerdoftheherd.com/tools/radiodld/
GNU General Public License v3.0
15 stars 11 forks source link

Stopped comments in RSS podcast feeds preventing them from loading. #115

Closed ribbons closed 11 years ago

ribbons commented 11 years ago

Original report from wayland28pds@btinternet.com at 01:48:18 on 2010-05-31

There seem to be two kinds of podcast feed which the Radio Downloader doesn't handle. The first is the CBC Radio podcast feed such as Vinyl Cafe. I know the feed is valid because it works in Google Reader, but Radio Downloader says: "The data returned from the specified URL was not a valid RSS feed". The feed in question is: http://www.cbc.ca/podcasting/includes/vinylcafe.xml

Another type of feed which works perfectly in Google Reader but not in Radio Downloader is the M-Radio or Radio Mensa feed: http://radiomensa.net/podcasts-only/rss2.aspx or, alternatively: http://radiomensa.net/atom.aspx these aspx feeds cause the same error message: "The data returned from the specified URL was not a valid RSS feed".


Imported from Bug 272 in the NerdoftheHerd.com Bugzilla.

ribbons commented 11 years ago

Original comment from Matt Robinson at 12:05:28 on 2010-05-31

I've had a look at http://www.cbc.ca/podcasting/includes/vinylcafe.xml and for some reason the comment tag in this prevents it from being recognised as valid XML by the XmlDocument.LoadXml method.

However, using the XmlDocument.Load method with a stream input instead causes it to load without errors, and seems to be a generally more reliable way of loading XML data, so that looks like the best way of implementing this.

http://radiomensa.net/atom.aspx is an atom feed, which isn't currently supported by Radio Downloader (but feel free to raise a bug requesting support for them).

However, http://radiomensa.net/podcasts-only/rss2.aspx loads fine for me and displays a list of episodes. This could have been a temporary problem with the feed itself.

ribbons commented 11 years ago

Original comment from Matt Robinson at 12:09:04 on 2010-05-31

Fix described above implemented in c11df8d.