search

ribbons / RadioDownloader

An easy to use application for managing podcast subscriptions and downloads.
https://nerdoftheherd.com/tools/radiodld/
GNU General Public License v3.0
15 stars 11 forks source link

Moved code from Data class into individual data model classes. #156

Closed ribbons closed 11 years ago

ribbons commented 11 years ago

Original report from Matt Robinson at 15:27:37 on 2011-09-25

Most of the code which handles both the 'business logic' and database access is contained within the Radio Downloader 'Data' class. However, this class is now getting rather large and unmanageable (nearly 2500 lines), and could do with being split up.

It would seem a better architecture to convert the ProgrammeData, SubscriptionData, FavouriteData, EpisodeData and DownloadData structs in the Data class into separate data model classes (using inheritance to reduce duplication), also containing the methods relating to that type of item, and static events for when an object of that type is added, updated or removed.

Imported from Bug 549 in the NerdoftheHerd.com Bugzilla.

ribbons commented 11 years ago

Original comment from Matt Robinson at 20:05:26 on 2013-08-13

This has finally been completed in 990b9167fc51ae8e6f156bdd10f80c414e75197c with the rename of the remainder of the 'Data' class to 'FindNew'. The change was completed over far too many commits to mention individually since this was raised!