ribbons / RadioDownloader

An easy to use application for managing podcast subscriptions and downloads.
https://nerdoftheherd.com/tools/radiodld/
GNU General Public License v3.0
15 stars 11 forks source link

The episode name and description are now passed correctly to providers when downloading. #163

Closed ribbons closed 11 years ago

ribbons commented 11 years ago

Original report from David Thomson at 18:23:22 on 2011-11-13

When Convert 'AAC to MP3' is left unselected the tag data that is attached to the file is only specific to the source type (eg. Afternoon Play) and in title and Comments does not contain any specific data about the particular episode.

Whilst this option is useful because on my 4 core processor I can use a specialist program (xrecode2) to very quickly do the conversion to MP3 and therefore the processor time for downloads/conversion is greatly shorter, any convenience gained is lost because of the absence of useful tag data.

If this is not an error, but a limitation caused by this option, then this route to curtail the extended download/conversion time is not viable if you require accurate tag data


Imported from Bug 573 in the NerdoftheHerd.com Bugzilla.

ribbons commented 11 years ago

Original comment from Matt Robinson at 19:10:35 on 2011-11-14

I've just downloaded an episode in AAC format and I can see the title and comments okay in the Windows Explorer Properties -> Details tab (Windows 7) and using MediaInfo.

What are you using to view the metadata?

ribbons commented 11 years ago

Original comment from David Thomson at 20:08:09 on 2011-11-14

I use MP3tag and can confirm with my downloaded copy what I described is accurate.

For example I copied the following from the tag data displayed in MP3tag for a particular show:

Filename:Woman's Hour Drama Journey to Starlight Mountain Episode 1.m4a Title:Woman's Hour Drama Artist:BBC Radio 4 Album:Woman's Hour Drama Comment:Classic and contemporary original drama and book dramatisations

At the same time the info pane in the listing window had the following specific comment content different from the generic comment content in the transfered tag, but the generic tag was inherited by the mp3 tag after it was transcoded by xrecode2.

Comment from info pane:By Sarah Daniels. Heart-warming new drama inspired by one of BBC Children in Need's projects. Mia's dreams of a rollercoast

It appears, however, my guess at the cause is wrong - since after reverting back to carrying out the internal Radio Downloader transcoding the same generic details in the comment field are displayed on later downloads, despite the specific episode data still being available in the info pane to the left of the listing.

From the evidence I now have it seems the change in the comment field came when I downloaded the latest beta version.

I have a second unmodified copy of Radio Downloader on a second computer and will in the next day compare the outputs of the two versions as regards the comment field.

ribbons commented 11 years ago

Original comment from Matt Robinson at 20:48:21 on 2011-11-14

Now I see what you mean - from your initial report it wasn't clear that the tags were being set, but with the programme rather than episode information.

Well spotted - the incorrect tagging is being caused by the application passing the programme name and description instead of the episode data to the provider, which I managed to introduce as a copy-paste error while doing some refactoring.

ribbons commented 11 years ago

Original comment from Matt Robinson at 20:53:18 on 2011-11-14

Resolved in 47d4ba2.

ribbons commented 11 years ago

Original comment from David Thomson at 21:21:26 on 2011-11-14

To correct the beta version I'm currently running I would be grateful for an emailed link as soon as it is possible.

Thanks

ribbons commented 11 years ago

Original comment from Matt Robinson at 22:18:18 on 2011-11-14

To correct the beta version I'm currently running I would be grateful for an emailed link as soon as it is possible.

Unless any serious issues come up in the 0.21 beta and I have to release further betas the fix will be included as part of the 0.22 release.