ribbons / RadioDownloader

An easy to use application for managing podcast subscriptions and downloads.
https://nerdoftheherd.com/tools/radiodld/
GNU General Public License v3.0
15 stars 11 forks source link

Fixed crash when moving / renaming existing downloads if there are less than 100 in the list. #164

Closed ribbons closed 11 years ago

ribbons commented 11 years ago

Original report from martin at 20:10:25 on 2011-11-22

I changed file naming to %progname%\%day%-%month%-%year% %epname% and clicked on "Yes" when asked "Rename existing downloads to new naming format". At this point Radio Downloader throws up an error message, reports home and then closes. This is repeatable.

Windows 7 Pro x64, plenty drive space.


Imported from Bug 577 in the NerdoftheHerd.com Bugzilla.

ribbons commented 11 years ago

Original comment from Matt Robinson at 20:29:46 on 2011-11-22

Just beat me to the draw, I was in the middle of writing a bug report for this issue when your report came in (it is currently the top crash in version 0.22).

The crash only occurs if there are less than 100 entries in the downloads list, due to the code setting the value of the progress bar on the status form to 100 instead of the actual max value (which is the number of downloads).

It crashes at the end of updating the downloads, so the workaround is to choose 'Yes' the first time and let it crash, and then change the setting(s) again and choose 'No'.

ribbons commented 11 years ago

Original comment from Matt Robinson at 19:30:50 on 2011-11-23

Resolved in 8b0fd74 by setting the progress bar value to the max value instead of 100 at the end of moving downloads.

ribbons commented 11 years ago

Original comment from martin at 22:01:45 on 2011-11-23

is 8b0fd74 available somewhere, or do I need to wait for a future release?

ribbons commented 11 years ago

Original comment from Matt Robinson at 22:08:49 on 2011-11-23

is 8b0fd74 available somewhere, or do I need to wait for a future release?

Yes, I'm afraid you'll need to wait for the next release for the fix - though the workaround above should keep you going in the meantime.