search

ribbons / RadioDownloader

An easy to use application for managing podcast subscriptions and downloads.
https://nerdoftheherd.com/tools/radiodld/
GNU General Public License v3.0
15 stars 11 forks source link

Improve performance when storing images. #179

Closed ribbons closed 8 years ago

ribbons commented 11 years ago

Original report from Matt Robinson at 20:49:22 on 2012-07-17

Currently, when storing an image in the database the query to test if there is an existing identical image can take several seconds to run if the database contains a large number of images. Performance could be improved considerably by adding a UNIQUE constraint against the image column so that it is indexed (and would also ensure that duplicate images aren't ever inserted).

However, migrating the image data into a new table with the additional constraint is quite slow, and the index does take up quite a lot more space on disk so it would be best to implement this in the version after issue #61 is resolved.

Imported from Bug 674 in the NerdoftheHerd.com Bugzilla.

ribbons commented 11 years ago

Original comment from Matt Robinson at 20:51:04 on 2012-07-17

It may also be necessary to add a progress dialog to the database schema update so that users know that the application is actually doing something.

ribbons commented 8 years ago

As this would cause the database to take up a considerable amount more disk space, I don't think that this is a good approach anymore. The time taken to save images is now be less of an issue as #61 has been implemented and should be even less of a problem when #210 is implemented too.