search

ribbons / RadioDownloader

An easy to use application for managing podcast subscriptions and downloads.
https://nerdoftheherd.com/tools/radiodld/
GNU General Public License v3.0
15 stars 11 forks source link

Fixed crash on start with 3rd party Windows shell which doesn't implement ITaskbarList3 #214

Closed tordenflesk closed 6 years ago

tordenflesk commented 7 years ago

"The method or operation is not implemented" on first start

screenshot

ribbons commented 7 years ago

What version of Windows are you running? Also, are you running a custom shell instead of Explorer?

tordenflesk commented 7 years ago

Windows 7 x64, BBZero 1.18. Seeing the references to the taskbar in the error I figured RadioDownloader would somehow be shell-dependent... Ran fine on a fresh user-account running explorer.exe

ribbons commented 7 years ago

Without looking at the source, it looks like it is crashing because BBZero doesn't implement the standard Windows 7 taskbar overlay icon functionality. Would it be sensible to just ignore the failure and not show any download status outside the application, or should we probe for the functionality first and fall back to using the system-tray icon if it isn't available (as we do with older versions of Windows)?

tordenflesk commented 7 years ago

Either will work for me personally, but I guess option two would be good for those who need to see status.

On 23.05.2017 21:35, Matt Robinson wrote:

Without looking at the source, it looks like it is crashing because BBZero doesn't implement the standard Windows 7 taskbar overlay icon functionality. Would it be sensible to just ignore the failure and not show any download status outside the application, or should we probe for the functionality first and fall back to using the system-tray icon if it isn't available (as we do with older versions of Windows)?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ribbons/RadioDownloader/issues/214#issuecomment-303508467, or mute the thread https://github.com/notifications/unsubscribe-auth/ACCal7xYiT0KGdKAe0pVimMZYiWTZqn0ks5r8zUTgaJpZM4Ni55A.

--

mvh. Esben