Resolved download errors connecting to servers only supporting TLS 1.1 and 1.2

ribbons / RadioDownloader

An easy to use application for managing podcast subscriptions and downloads.

https://nerdoftheherd.com/tools/radiodld/

GNU General Public License v3.0

15 stars 11 forks source link

Resolved download errors connecting to servers only supporting TLS 1.1 and 1.2 #223

Closed BrianG61UK closed 6 years ago

BrianG61UK commented 6 years ago

Please fix RadioDownloader so it can download episode 135 from: http://rss.acast.com/techsmessage Thank you.

ribbons commented 6 years ago

Thanks for your bug report. I've just tried downloading episode 135 of the RSS feed that you shared and it works okay for me.

To help me narrow the issue down, could you give me a couple of bits of info:

The version of Radio Downloader that you are you using
The error message that you are getting? A screenshot can also be handy.

BrianG61UK commented 6 years ago

Thank you.

I am using Radio Downloader 0.30-0-g2b64de7

Screenshot of error is attached.

ribbons commented 6 years ago

Screenshot of error is attached.

Unfortunately the screenshot didn't come through, could you try directly uploading it to the issue on GitHub instead of emailing it? You can drag and drop the image file into the comment box.

BrianG61UK commented 6 years ago

Sorry. Here it is: rdl err 1

ribbons commented 6 years ago

No worries :smiley:

If you click on the failed download what error message does it show in the sidebar?

BrianG61UK commented 6 years ago

Error: Unknown error An unknown error occurred when trying to download this programme. Press the... rdl err 2

ribbons commented 6 years ago

Okay. Could you install the build from https://ci.appveyor.com/project/ribbons/radiodownloader/build/165/job/rlrttjyyp9yoancd/artifacts and retry the download?

BrianG61UK commented 6 years ago

I installed the new version. Radio Downloader 0.30-74-89488aa9 The error looks the same but when I press report error I am now given a report number. I reported the error as, if I remember correctly, 55791, 55792 and 55793.

ribbons commented 6 years ago

Perfect, thanks - this is the exception:

System.Net.WebException: The underlying connection was closed: An unexpected error occurred on a send. ---> System.IO.IOException: Authentication failed because the remote party has closed the transport stream.
   at System.Net.TlsStream.EndWrite(IAsyncResult asyncResult)
   at System.Net.PooledStream.EndWrite(IAsyncResult asyncResult)
   at System.Net.ConnectStream.WriteHeadersCallback(IAsyncResult ar)
   --- End of inner exception stack trace ---
   at PodcastProvider.PodcastProvider.DownloadProgramme(String progExtId, String episodeExtId, ProgrammeInfo progInfo, EpisodeInfo epInfo, String finalName) in C:\projects\radiodownloader\Providers\PodcastProvider\Classes\PodcastProvider.cs:line 455
   at RadioDld.DownloadHandler.DownloadProgThread() in C:\projects\radiodownloader\Classes\DownloadHandler.cs:line 224

I can also reproduce the issue under Windows 7. Think it might be TLS related in some way, but I'm not totally sure...

BrianG61UK commented 6 years ago

Thanks for the update.

ribbons commented 6 years ago

Could you try the build from here and let me know if it makes a difference: https://ci.appveyor.com/project/ribbons/radiodownloader/build/175/job/ta4sakcq54c2gfpy/artifacts

BrianG61UK commented 6 years ago

Thank you very much, that seems to have fixed it.

ribbons commented 6 years ago

Thank you very much, that seems to have fixed it.

Great - glad to hear it. I'll push that change to master so that it is included in the next release.