search

ribbons / RadioDownloader

An easy to use application for managing podcast subscriptions and downloads.
https://nerdoftheherd.com/tools/radiodld/
GNU General Public License v3.0
15 stars 11 forks source link

Stop treating Podcast episodes with URL encoded enclosure URLs as invalid #226

Closed cjpcjpindre closed 5 years ago

cjpcjpindre commented 5 years ago

Hi,

Have added a feed to RD: https://anchor.fm/s/7368c04/podcast/rss

RD was quite happy to add it, so recognised it as an rss feed. But it has not downloaded anything from the feed. Current Episode list empty in RD. Browsing the rss feed shows Four Episodes.

Not sure if this is bug in RD, or dodgy encoding on the rss feed.

ribbons commented 5 years ago

Thanks for your bug report - I can reproduce this problem.

The reason it isn't showing any episodes is that the episode audio file (enclosure) URLs are checked with Uri.IsWellFormedUriString to make sure they are valid and this is returning false for all of the URLs in the feed, causing them to be skipped over.

However what I'm not quite seeing at the moment is why IsWellFormedUriString is returning false - as an example, this is one of the URLs in the feed which doesn't look obviously invalid but fails the test.

https://anchor.fm/s/7368c04/podcast/play/1722642/https%3A%2F%2Fd3ctxlq1ktw2nl.cloudfront.net%2Fstaging%2F2018-10-13%2FJohn-Kearns-782f1f393cd0f.m4a
ribbons commented 5 years ago

Right, I managed to get to the bottom of this in the end :smile:.

If you'd like to download and install the build of Radio Downloader from here it should then list the episodes of that podcast feed correctly. Let me know how you get on...

cjpcjpindre commented 5 years ago

Hi,

Thanks, (as ever) for the quick response.

I've installed the new build. Partial success. RD is listing the episodes: screenshot 101

However, there is the following error when trying to download the latest episode after subscribing: "Error: Not available This episode appears to be no longer available. You can either try again later, or cancel the download to remove it from the list and clear the error."

ribbons commented 5 years ago

Turns out I should have tested actually downloading the episodes too :smile:. I'll close this bug and open a new one for the downloading issue as from a quick look it is being caused by a related but slightly different issue.