search

ribbybibby / ssl_exporter

Exports Prometheus metrics for TLS certificates
Apache License 2.0
520 stars 97 forks source link

exporter leaking file descriptors #30

Closed tommywo closed 4 years ago

tommywo commented 4 years ago

After some time ssl_exporter is unable to scrape targets.

time="2020-06-04T11:39:37Z" level=error msg="Get https://example.com:443: dial tcp: lookup example.com on 8.8.8.8:53: dial udp 8.8.8.8:53: socket: too many open files" source="ssl_exporter.go:108"

Similar issue happend in different exporter: https://github.com/bosh-prometheus/shield_exporter/issues/3 , fixed in pull request: https://github.com/shieldproject/shield/pull/280/files

ribbybibby commented 4 years ago

Thanks for the issue @tommywo! This PR seems to resolve the issue for me: https://github.com/ribbybibby/ssl_exporter/pull/31. Does that look good to you?

tommywo commented 4 years ago

Yes. Thank you :)

ribbybibby commented 4 years ago

Fixed in v1.0.1