search

ribbybibby / ssl_exporter

Exports Prometheus metrics for TLS certificates
Apache License 2.0
507 stars 95 forks source link

Export OCSP stapling metrics #54

Closed ribbybibby closed 3 years ago

tykling commented 3 years ago

This looks great! One question, how would the values look if the certificate had no OCSP response stapled to it? Would it make sense to add a 0/1 metric specifically for determining this?

ribbybibby commented 3 years ago

@tykling Yep, that makes sense to me. I've added that.

tykling commented 3 years ago

hello, is there anything I can do to expedite getting this merged?

ribbybibby commented 3 years ago

Hi @tykling.

I need to rebase on top of some other changes that have been merged to master, I'll try to get to that today.

I would appreciate any further comments you have on the changes, or a thumbs up if it looks okay. After that I'm happy to merge.

tykling commented 3 years ago

Looks good apart from the small docs thing :+1:

ribbybibby commented 3 years ago

Great, thanks for the review! I've amended the README and rebased, so I'm going to merge now. I'll look at cutting a release soon, I just need to check if there are any other changes pending implementation that I'd like to sneak in first.