ribbybibby / ssl_exporter

Exports Prometheus metrics for TLS certificates
Apache License 2.0
507 stars 95 forks source link

allow module and target be configured via flags #68 #69

Closed hroongtanew closed 2 years ago

hroongtanew commented 3 years ago

https://github.com/ribbybibby/ssl_exporter/issues/68

hroongtanew commented 3 years ago

@ribbybibby

ribbybibby commented 3 years ago

I don't think this should be configured via flags. I think it would be better in the config file.

Maybe like this?

default_module: "tcp_target"
modules:
  tcp_target:
    prober: "tcp"
    target: "example.com:443" # configured per-module for extra flexibility
ribbybibby commented 2 years ago

Added here: https://github.com/ribbybibby/ssl_exporter/commit/02d61835e831b0fe48bd8859a0c5b69bd74a7243