search

ribbybibby / ssl_exporter

Exports Prometheus metrics for TLS certificates
Apache License 2.0
507 stars 95 forks source link

[added] release target add loongarch64 #70

Closed stan1334 closed 3 years ago

stan1334 commented 3 years ago

[added] release target add loongarch64

loongarch64 is Loongson's latest instruction set, and the server market has a lot of users in China.

PTAL.thanks。 @ribbybibby

stan1334 commented 3 years ago

IIRC LoongArch support is not upstream in Go? Even the proposal golang/go#46229 hasn't been accepted yet, the exact GOARCH value hasn't been decided. Maybe we should wait a bit?

Also the English in commit message is a bit broken, and doesn't adhere to project convention. Maybe something like "Add loongarch64 to release targets" would be better. (Of course, change the "loongarch64" part to whatever gets finally accepted as the GOARCH value to use.)

You are right. Currently, cross-compilation does not support loongarch64, and the field of goarch has not yet been determined. I will continue to follow up, thank you for your reminder.

stan1334 commented 3 years ago

Wait until the goarch field is confirmed and cross-compilation is supported, and then resubmit.