search

ribbybibby / ssl_exporter

Exports Prometheus metrics for TLS certificates
Apache License 2.0
507 stars 95 forks source link

Update dependencies #76

Closed johanfleury closed 2 years ago

johanfleury commented 3 years ago

I’m not sure how to update dependencies so what I did is to change github.com/prometheus/common version to 0.29.0 in go.mod then to run go mod tidy and go mod vendor.

This is something I didn’t catch in #71 as there’s not much debug logging in the code.

Fixes #75

johanfleury commented 3 years ago

BTW, is there a reason to vendor dependencies?

ribbybibby commented 3 years ago

BTW, is there a reason to vendor dependencies?

There used to be but I don't think there's any reason to do it now. Seen as the scope of this PR is updating deps, I'd be happy to ditch it here.

johanfleury commented 3 years ago

I removed the vendor directory, I hope that’s all that is needed.