search

ribbybibby / ssl_exporter

Exports Prometheus metrics for TLS certificates
Apache License 2.0
507 stars 95 forks source link

Add helm-chart (#14) #79

Open dromaniuk opened 2 years ago

dromaniuk commented 2 years ago

Hi. I've added simple helm chart. It makes available to deploy it to Kubernetes with Prometheus Operator compatibility (Config is being declared as Probes).

I've checked it on Kubernetes 1.19

dromaniuk commented 2 years ago

One thing I think that should be added is a way to add configMap and secret volumes + volumeMounts so that users can provide the config file and mount certificates in the exporter container.

I've added configMap generation in 546a1c411574a65ef59325c632031a001a04f8b5 The rest whould be better to implement later as chart improvements. They take quite more time, than I expected. So I propose to apply this pull-request for the beginning, and "polish" the chart next time.

dromaniuk commented 2 years ago

Any updates? Seems the pull-request has been forgotten

ribbybibby commented 2 years ago

Sorry @dromaniuk, I haven't had much time to dedicate to this project recently.

Could you please add the ability to mount secrets as requested? This is a very common requirement for people using their own PKI or client authentication and I would prefer that the chart had that functionality. My concern is that if it's left til 'next time', that 'next time' isn't going to come around.

etiennejournet commented 2 years ago

Hi @dromaniuk, thanks for your work, I can help you on this if you don't have time. Have you considered adding the proper rbac template to allow for monitoring secrets inside of the same cluster the container is deployed in ?

dromaniuk commented 2 years ago

Hi @dromaniuk, thanks for your work, I can help you on this if you don't have time. Have you considered adding the proper rbac template to allow for monitoring secrets inside of the same cluster the container is deployed in ?

@etiennejournet I will be very grateful for your help.

etiennejournet commented 2 years ago

Hey, I have no time for now but keeping this in mind. I'll come back to you asap