search

ribbybibby / ssl_exporter

Exports Prometheus metrics for TLS certificates
Apache License 2.0
525 stars 99 forks source link

Add support for setting server_name as query parameter #80

Closed johanfleury closed 2 years ago

johanfleury commented 2 years ago

Implements #74

ribbybibby commented 2 years ago

The same proposal has been rejected in the blackbox_exporter: https://github.com/prometheus/blackbox_exporter/issues/624.

I'm sympathetic to the reasoning there that this issue can be solved by configuration management.

k0ste commented 2 years ago

I agree that this possible to cover cases like this via IaC, in per-module manner. We do it like this with ssl_exporter Ansible role

johanfleury commented 2 years ago

I’m closing the PR as I’m not using ssl_exporter that way anymore since I left my previous company.

I still think that having to manage a configuration file is a pain, especially when you already have everything you need in the service discovery labels.

Of course everything is always possible (depending on the time you’re willing to put into it), but managing the configuration dynamically in the Kubernetes context (in which this issue arose) is not the simplest thing to do.

ldaneliukas commented 1 year ago

@ribbybibby seeing as blackbox_exporter now accepts hostname as a parameter, can this be re-opened?