ribice / kiss

Stupidly simple Hugo blogging theme
https://themes.gohugo.io/theme/kiss/
MIT License
295 stars 130 forks source link

Do not use target="_blank" for social media links #103

Closed DanielRuf closed 2 years ago

DanielRuf commented 3 years ago

target="_blank" is bad for the accessibility and for the security, you also forgot to add noreferrer to the rel attribute.

See also https://blog.daniel-ruf.de/target-blank-considered-harmful/.

DanielRuf commented 3 years ago

What is the preferred solution? Remove the target attribute or set the rel attribute to mitigate tab nabbing attacks?

ribice commented 3 years ago

I have no idea to be honest. Most of my work is backend/devops and I rarely touch HTML besides some basics. Feel free to implement whatever you consider better.