ribizli / ng2-imageupload

A component which resizes the selected file image
29 stars 10 forks source link

***Suggest naming! - Renaming the module for new angular naming convention #18

Open saiyaff opened 7 years ago

saiyaff commented 7 years ago

Here's the link explains it. Link

ribizli commented 7 years ago

I don't think it's a big thing to keep legacy names, anyway I don't want to confuse the users with this, and pollute npm with a new name (or with the obsolete one).

ribizli commented 7 years ago

I was thinking about the rename. The current naming imageupload doesn't reflect really what this module/directive does: resizing and converting the selected images into a dataUrl. I'd like to use this issue to comment about suggested renamings. In this process we can also rename the ng2 prefix to be just ng or angular.

DoKraus commented 7 years ago

"ng" implies for the old angular-1.x version (angularjs) I've seen in another project the prefix "ngx" - and I think that's fine ...

here are some suggestions (without prefix):