search

ribl / FBAnnotationClusteringSwift

Swift translation of FB Annotation Clustering, which clusters pins on the map for iOS.
http://ribl.co/blog/2015/05/28/map-clustering-with-swift-how-we-implemented-it-into-the-ribl-ios-app/
MIT License
311 stars 109 forks source link

Update Swift 4? #76

Open josepfm opened 7 years ago

josepfm commented 7 years ago

Could you update to Swift 4?

When I try to run do not work because it is necessary the update to Swift 4.

josepfm commented 7 years ago

hello?

Tsourdox commented 7 years ago

This would be really nice!

chenr2 commented 7 years ago

Sorry, I haven't been maintaining this repo -- I just did the original translation from Objective-C to Swift a long time ago, and put it out there for the community to do what they want with it. I'm open to pull requests though.

If you're not tied to backward compatibility, iOS 11 does have map clustering built in: https://developer.apple.com/documentation/mapkit/mkclusterannotation

And a nice sample project (click "Download Sample Code" button on the top left): https://developer.apple.com/library/content/samplecode/PhotoMap/Introduction/Intro.html

antoinelamy commented 6 years ago

@chenr2 do you have the rights on this repo? I rewrote the entire thing a year ago and it’s sad to see its left for dead state. If I could get the rights, I would be happy to maintain it.

chenr2 commented 6 years ago

@antoinelamy Thanks for all your hard work. I added you as a collaborator. Let me know if there's anything else I should do to give you access.

josepfm commented 6 years ago

Quizás quisiste decir Genial. Espero que nos avise cuando esté actualizado a Swift 4 Great.

I hope you let us know when you are updated to Swift 4!!

pasevin commented 6 years ago

I've submitted PR, works with Swift 4.2 https://github.com/ribl/FBAnnotationClusteringSwift/pull/80