search

riboseinc / asciidoctor-bibliography

Citations in AsciiDoc
MIT License
30 stars 8 forks source link

An empty cite:[] is being read in the commented block and it stops #75

Closed shahryareiv closed 5 years ago

shahryareiv commented 6 years ago

If there is an empty citation cite:[], even in a commented block, it stops and alarms: "Failed to load AsciiDoc document - No entry with id '' was found in the bibliographic database". There are two things to consider: 1- A comment block is comment and should not be converted 2-It is common to put an empty citation cite:[] to fill in later. In latex those empty citations \cite{} are translated to ?? so the user would see them later in the text.

ronaldtse commented 6 years ago

@shahryareiv thanks for the report. The error occurring in a comment certainly makes it a bug.

On the other hand, I agree that empty citations can be filled in later, so we should make this an enhancement in addition to fixing the above.

@paolobrasolin would you have time for this? Thanks!

paolobrasolin commented 5 years ago

Solved by #80 and merged in v0.9.0. Thanks for the report @shahryareiv