search

riboseinc / asciidoctor-bibliography

Citations in AsciiDoc
MIT License
30 stars 8 forks source link

Fix for #84 issues #89

Closed CAMOBAP closed 5 years ago

CAMOBAP commented 5 years ago
CAMOBAP commented 5 years ago

@ronaldtse I can help with fixing .rubocop.yml just let me know. I have checked the problem in outdated .oss-guides.rubocop.yml

ronaldtse commented 5 years ago

@CAMOBAP795 please also help with Rubocop. Thanks!

CAMOBAP commented 5 years ago

@ronaldtse codeclimat conflicts with rubocop about 'trailing spaces' which behavior we should fixate? https://github.com/bbatsov/ruby-style-guide#no-trailing-array-commas

CAMOBAP commented 5 years ago

@ronaldtse codeclimat conflicts with rubocop about 'trailing spaces' which behavior we should fixate? https://github.com/bbatsov/ruby-style-guide#no-trailing-array-commas

FYI have changed Style/TrailingCommaInHashLiteral rule in rubocop

PR is ready for review again

ronaldtse commented 5 years ago

Thank you @CAMOBAP795 !